Text log view blueprint properties #11896
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
IsseW
added
📺 re_viewer
IsseW
force-pushed
the
isse/bp-log
branch
2 times, most recently
from
b7906d5 to
8ebcb50
Compare
|
Updating the snippet here and making the python api a bit nicer for this now too. But I think the rust side should be good to review. |
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
core logic lgtm but we probably should talk about those list wrapper types :/
crates/store/re_types/definitions/rerun/blueprint/archetypes/text_log_columns.fbs
Outdated
Show resolved
Hide resolved
crates/store/re_types/definitions/rerun/blueprint/datatypes/text_log_column_list.fbs
Outdated
Show resolved
Hide resolved
crates/store/re_types/definitions/rerun/blueprint/datatypes/text_log_level_list.fbs
Outdated
Show resolved
Hide resolved
crates/store/re_types/src/blueprint/components/text_log_level_list_ext.rs
Outdated
Show resolved
Hide resolved
crates/viewer/re_component_fallbacks/src/blueprint_component_fallbacks.rs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| // We need this to be a custom ui to bew able to use the view state to get seen text log levels. This could potentially be avoided if we could add component ui's from this crate. |
There was a problem hiding this comment.
| // We need this to be a custom ui to bew able to use the view state to get seen text log levels. This could potentially be avoided if we could add component ui's from this crate. | |
| // We need this to be a custom ui to be able to use the view state to get seen text log levels. | |
| // This could potentially be avoided if we could add component ui's from this crate. |
well. so.. we actually can add component uis from this crate. Would be a first, but don't think there's anything to prevent us doing that in on_register
There was a problem hiding this comment.
Didn't succeed in making it a registered UI because it would need a view context to get the view state. While component UI's get viewer context. So would need something more similar to the fallback registry in that case, where component UI's registered in a view's on_register get registered for that specific view. And used with that specific view context.
| ); | ||
| } else { | ||
| code.push_indented(1, "typed_data = data", 2); | ||
| } |
There was a problem hiding this comment.
would we prefer _ext classes over this?
This applied to the two cases I had, with no existing cases that had both overrode init and a python alias.
Allows us to do ["some", "timelines"], which from the type hint of the function you'd expect.
Related
What
Moves text log view properties to blueprint.